identifier normalizer code review#1820
Merged
Merged
Conversation
Simperfit
approved these changes
Apr 6, 2018
soyuka
force-pushed
the
fix/identifier-normalizer-1309
branch
from
April 6, 2018 13:09
b2b0e9e to
db038f0
Compare
meyerbaptiste
requested changes
Apr 6, 2018
| { | ||
| $keys = $this->identifiersExtractor->getIdentifiersFromResourceClass($class); | ||
|
|
||
| if (empty($keys)) { |
soyuka
force-pushed
the
fix/identifier-normalizer-1309
branch
from
April 6, 2018 13:25
db038f0 to
81e1ea6
Compare
meyerbaptiste
approved these changes
Apr 6, 2018
soyuka
force-pushed
the
fix/identifier-normalizer-1309
branch
3 times, most recently
from
April 6, 2018 15:20
853dda8 to
78a54c6
Compare
Member
|
@soyuka That makes me think the contract of the |
Member
Author
|
don't merge yet please @Simperfit :p |
soyuka
force-pushed
the
fix/identifier-normalizer-1309
branch
from
April 6, 2018 17:28
1d71cee to
7a45c98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ping @meyerbaptiste